feat: update handler and middleware to allow no sig on keys message and no check on decryption trigger #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannikluhn
reviewed
Aug 5, 2025
| @@ -177,48 +177,6 @@ func validateSignerIndices(extra *p2pmsg.ShutterServiceDecryptionKeysExtra, n in | |||
| return pubsub.ValidationAccept, nil | |||
| } | |||
|
|
|||
| func ValidateDecryptionKeysSignatures( | |||
There was a problem hiding this comment.
I think it's a bit safer to still validate the signatures as normal if they are there, but allow for messages that have empty signer indices and signatures. We probably don't want to allow for invalid signatures in messages.
blockchainluffy
force-pushed
the
test/allow-keys-msg-no-sig
branch
from
260eccb to
d4c3a50
Compare
jannikluhn
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #620